-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix top margin in empty versions list #35063
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
st3iny
commented
Nov 9, 2022
•
edited
Loading
edited
Before | After |
---|---|
st3iny
added
bug
design
Design, UI, UX, etc.
3. to review
Waiting for reviews
feature: versions
labels
Nov 9, 2022
st3iny
requested review from
szaimen,
a team,
skjnldsv and
Pytal
and removed request for
a team
November 9, 2022 22:11
/backport to stable25 |
/backport to stable24 |
/backport to stable23 |
szaimen
approved these changes
Nov 9, 2022
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
fix/noid/versions-empty-top-margin
branch
from
November 9, 2022 22:22
91b9a56
to
e122a50
Compare
Pytal
approved these changes
Nov 9, 2022
Pytal
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Nov 9, 2022
This was referenced Nov 10, 2022
The backport to stable23 failed. Please do this backport manually. |
/backport to stable23 |
The backport to stable23 failed. Please do this backport manually. |
st3iny
added a commit
that referenced
this pull request
Nov 10, 2022
Manual backport of #35063 Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
bug
design
Design, UI, UX, etc.
feature: versions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.