Add version naming UI

[artonge]

⚠️ ⚠️
New elements are not visible by default. Need to set OC.experimental = true in the console before opening the sidebar.
⚠️ ⚠️

Context	Screenshot
List of version with the actions menu opened for the current version
List of version with the actions menu opened for a previous version
Name editor when the version do have a name
Name editor when the version does not have a name

Need #34769

[artonge]

@jancborchardt or @nimishavijay for early design review :)

• I did not add a "Cancel" button" in the name version modal, as it seems like we do not do that in other place.
• Should I add a "Create new version" at the top of the list or something ?
• Let me know if I missed another requirement

[jancborchardt]

Very nice! :) Some design feedback:

• The pencil icon for "Name this version" is a bit complex, just use the regular "pencil" material design icon
• "Restore version" can go before "Download version" in the menu
• The modal needs a heading inside, saying "Version name"
• The "Named versions are persisted …" info text should go below the input field, and be in color-text-maxcontrast
• Is the "Version name" input field focused by default?
• If there is no version name or if the field is empty, the "Remove version name" button can be disabled?
• Let’s use a better icon than the floppy for saving :D Just the "done" checkmark is fine

I did not add a "Cancel" button" in the name version modal, as it seems like we do not do that in other place.

I’d say an "x" in the top right would be nice though. :)

Should I add a "Create new version" at the top of the list or something ?

I’d say no, since the current version is already there? You can name the current version, right? So that is enough.

Great work @artonge! :)

[artonge]

I’d say no, since the current version is already there? You can name the current version, right? So that is enough.

Now you can :)

[jancborchardt]

Very very nice @artonge! One last thing: Both "Current version" and "Initial version" i'd consider "virtual" names, not actual version names, so I'd label the action "Name this version" and have an empty input field in the modal. (But if the name is left empty for either the initial or current version, ofc this "virtual" name stays displayed in the version list.)

Does that make sense? :D

[artonge]

Both "Current version" and "Initial version" i'd consider "virtual" names

"Initial version" is a "random" name I set myself for testing. Do you want to have this "virtual" label for the first version as well ?

The other part makes sense :)

• Better handling of virtual label for the first and current versions

Edit: I've implemented the "Initial version" thing.

[szaimen]

just tested a bit and how can I set the version? Also I have two initial versions?

[artonge]

Ah, forgot to properly set the condition for initial version.
New buttons are not visible by default. You need to set OC.experimental = true in the console before opening the sidebar.
I just pushed a fix

[szaimen]

okay found it. A few more findings:

• showing the menu dots and/or icons only on hover does not work well on mobile
• I can use the same name for multiple items?

[artonge]

• showing the menu dots and/or icons only on hover does not work well on mobile

That should probably be fixed in nc-vue, no ?

• I can use the same name for multiple items?

Yes, unless @jancborchardt says otherwise :)

[szaimen]

Also, shouldnt the save version name button not only be enabled after you type in something?

[artonge]

Also, shouldnt the save version name button not only be enabled after you type in something?

This is so the user can remove the name. From Jan:

If there is no version name or if the field is empty, the "Remove version name" button can be disabled?

If we disable "Remove version name" then we can't also disable "Save version name".

[XueSheng-GIT]

@artonge thanks a lot! I really appriciate this approach to add version naming (and make such versions persistent)! I was looking for such a feature for quite some time.

Topics which might be considered:

• version numbers (e.g. automatically increased or manually defined), personally I'm used to SharePoint and a M.N version scheme (Major, minor numbers, whereas e.g. 4.0 would be a stable/released version and 4.8 would be a draft version ahead of 5.0). This provides a quick overview about the versions.
• descriptive text (optional) in addition to the the version name. Like you typically do for a github commit. This would be helpful to add some additional text about the version (and why it is important to keep or what was changed in comparison to previous versions).

[skjnldsv]

OC.experimental = true, what is this? This is no standard we have, right?
I'm not sure it's a good idea to add.

[PVince81]

@artonge in general I think feature flags, if we do them, should be done on capability level

now, if the backend is close to MVP maybe we can just merge the two PRs first and no need for a flag

[artonge]

Closing as it will get merged with #35160