Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Provide access to app generated calendars through CalDAV #35121

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Feature: Provide access to app generated calendars through CalDAV #35121

merged 1 commit into from
Apr 26, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 12, 2022 •
edited
Loading

This adds CalDAV support for app generated calendars, which are registered using OCP\Calendar\ICalendarProvider.

This is done by adding a DAV plugin which wraps all registered calendars, except the native CalDAV calendars, into a Sabre plugin (inspired by the @nextcloud/deck Sabre calendar plugin).

(see also this forum post: https://help.nextcloud.com/t/provide-custom-app-calendar/148753/1 )

Todo:

  • Add test cases

@susnux susnux added enhancement 2. developing Work in progress feature: caldav Related to CalDAV internals labels Nov 12, 2022
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 12, 2022
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@susnux susnux force-pushed the feat/dav-wrap-app-calendars branch from e87fd70 to 1df5239 Compare November 12, 2022 17:51
@susnux susnux force-pushed the feat/dav-wrap-app-calendars branch from 1df5239 to 2989deb Compare November 13, 2022 13:40
@susnux susnux force-pushed the feat/dav-wrap-app-calendars branch 2 times, most recently from c89826a to e592071 Compare November 13, 2022 14:57
@susnux susnux added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 13, 2022
@susnux
Copy link
Contributor Author

susnux commented Nov 13, 2022

I think this is ready for review 😃

@szaimen szaimen added this to the Nextcloud 26 milestone Nov 13, 2022
@miaulalala
Copy link
Contributor

Hi @susnux, thanks for your PR! I don't have time to look at it this week but I will review it next week.

Again, thanks for your work!

@miaulalala miaulalala self-assigned this Nov 15, 2022
@ChristophWurst
Copy link
Member

This looks great! Would it be possible to use your app for testing? I don't know of any other app that currently implements the new calendar APIs for apps.

@susnux susnux added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jan 12, 2023
@susnux susnux force-pushed the feat/dav-wrap-app-calendars branch from e592071 to 47909b0 Compare January 13, 2023 22:23
miaulalala
miaulalala approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@susnux susnux force-pushed the feat/dav-wrap-app-calendars branch from 47909b0 to c68f50b Compare January 16, 2023 13:02
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 16, 2023
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@susnux susnux requested a review from ChristophWurst April 18, 2023 15:12
@susnux susnux force-pushed the feat/dav-wrap-app-calendars branch from 05eb849 to 320cecd Compare April 18, 2023 15:18
ChristophWurst
ChristophWurst approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Apr 18, 2023
@ChristophWurst ChristophWurst requested a review from st3iny April 18, 2023 16:31
@ChristophWurst
Copy link
Member

This change should probably be mentioned in https://docs.nextcloud.com/server/latest/developer_manual/digging_deeper/groupware/calendar.html#calendar-providers

@susnux susnux mentioned this pull request Apr 18, 2023
Merged
@susnux susnux removed the pending documentation This pull request needs an associated documentation update label Apr 18, 2023
@susnux
Copy link
Contributor Author

susnux commented Apr 18, 2023

This change should probably be mentioned

Done in nextcloud/documentation#10073

st3iny
st3iny approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Drone failure seem to be unrelated.

@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 19, 2023
@ChristophWurst
Copy link
Member

Drone restarted

@miaulalala

This comment was marked as resolved.

Sign in to view
@ChristophWurst
Copy link
Member

https://drone.nextcloud.com/nextcloud/server/32884/36/3

DELETE /remote.php/dav/calendars/admin/MyCalendar this could be related

@susnux
Feature: Provide access to app generated calendars through CalDAV
62c4ae7 
This adds CalDAV support for app generated calendars,
which are registered to the nextcloud core.
This is done by adding a dav plugin which wraps
all ICalendarProviders into a Sabre plugin (inspired by the deck app).

Add unit test for AppCalendar wrapper plugin and calendar object implementation.

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
@susnux susnux force-pushed the feat/dav-wrap-app-calendars branch from 320cecd to 62c4ae7 Compare April 25, 2023 16:12
@susnux
Copy link
Contributor Author

susnux commented Apr 25, 2023

@ChristophWurst Both CI issues (drone and node tests) are not related. CI results of current master have the same issues.

@szaimen
Copy link
Contributor

szaimen commented Apr 26, 2023

So merge @ChristophWurst ?

@ChristophWurst ChristophWurst disabled auto-merge April 26, 2023 09:14
@ChristophWurst
Copy link
Member

Merge

@ChristophWurst ChristophWurst merged commit 5d29a96 into master Apr 26, 2023
@ChristophWurst ChristophWurst deleted the feat/dav-wrap-app-calendars branch April 26, 2023 09:15
@susnux susnux mentioned this pull request May 5, 2023
Closed
@ChristophWurst ChristophWurst mentioned this pull request Jun 26, 2023
Merged
@ChristophWurst ChristophWurst mentioned this pull request Oct 24, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@st3iny st3iny st3iny approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

Assignees

@miaulalala miaulalala

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: caldav Related to CalDAV internals
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
7 participants
@susnux @miaulalala @ChristophWurst @tcitworld @szaimen @st3iny @blizzz