Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[stable24] Fix quota type to int" #35334

Merged
merged 3 commits into from
Nov 25, 2022

Conversation

PVince81
Copy link
Member

Reverts #34032 to unbreak 32-bit quota setting.

See #34961 (comment)

@PVince81 PVince81 mentioned this pull request Nov 22, 2022
@szaimen

This comment was marked as resolved.

@blizzz blizzz mentioned this pull request Nov 23, 2022
9 tasks
@blizzz
Copy link
Member

blizzz commented Nov 23, 2022

CI is unhappy

@PVince81
Copy link
Member Author

cherry-picked 7bcd419 to hopefully fix CI

@PVince81
Copy link
Member Author

@CarlSchwan @come-nc can you help ?

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Id say lets move it to 24.0.9

@PVince81
Copy link
Member Author

seems I managed to make psalm happy by updating the baseline

I'll fix the DCO next

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 force-pushed the revert-34032-backport/34019/stable24 branch from 2ce3e3d to f8e18e5 Compare November 24, 2022 20:09
@szaimen
Copy link
Contributor

szaimen commented Nov 24, 2022

@PVince81can you make sure that this is tested?

@PVince81
Copy link
Member Author

tested, looks fine

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay for me then

@szaimen szaimen merged commit 87cbbb4 into stable24 Nov 25, 2022
@szaimen szaimen deleted the revert-34032-backport/34019/stable24 branch November 25, 2022 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants