Fix background theming deletion and cypress admin theming tests #35728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
PVince81,
artonge and
Pytal
and removed request for
a team
szaimen
approved these changes
Dec 11, 2022
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
force-pushed
the
fix/cypress
branch
from
2fbd1d5
to
6ead30c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
commented
Dec 11, 2022
skjnldsv
commented
Dec 11, 2022
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
skjnldsv
commented
Dec 11, 2022
skjnldsv
changed the title
only cypress test selector leftover
skjnldsv
force-pushed
the
fix/cypress
branch
2 times, most recently
from
89911b4
to
b28d97f
Compare
skjnldsv
added
2. developing
artonge
approved these changes
Dec 12, 2022
|
cypress failure ? or needs rebase / restart ? |
Need me to find time to dive into this again 🙈 |
Merged
Merged
Merged
|
@skjnldsv is this still relevant? |
|
Yes we should but I don't have time for this unfortunately :/ |
Merged
skjnldsv
force-pushed
the
fix/cypress
branch
2 times, most recently
from
79de33f
to
7d257eb
Compare
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
skjnldsv
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leftover from #35666...
Restore cypress proper testing specs... 😮💨
Follwup:
#0082c9colour with accessibility colour#006aa3.Will clarify with design team afterwards