Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put Mimeloader insertion and read in the same transaction #35744

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Put Mimeloader insertion and read in the same transaction #35744

merged 1 commit into from
Apr 17, 2023

Conversation

tcitworld
Copy link
Member

And modernize code a bit.

Checklist

@tcitworld tcitworld added the 3. to review Waiting for reviews label Dec 13, 2022
@tcitworld tcitworld added this to the Nextcloud 26 milestone Dec 13, 2022
@tcitworld tcitworld requested review from nickvergessen and a team December 13, 2022 08:55
@tcitworld tcitworld requested review from PVince81, icewind1991 and come-nc and removed request for a team December 13, 2022 08:55
@tcitworld tcitworld force-pushed the mimeloader-transaction branch 2 times, most recently from b655e41 to 532ace6 Compare December 13, 2022 09:15
@tcitworld tcitworld force-pushed the mimeloader-transaction branch from 532ace6 to e6c7d64 Compare December 14, 2022 08:30
@tcitworld tcitworld requested a review from come-nc December 14, 2022 08:30
@PVince81 PVince81 requested a review from artonge December 16, 2022 15:21
@tcitworld tcitworld force-pushed the mimeloader-transaction branch from e6c7d64 to de3fb63 Compare January 19, 2023 17:53
@tcitworld tcitworld mentioned this pull request Jan 19, 2023
Merged
4 tasks
@tcitworld tcitworld force-pushed the mimeloader-transaction branch from de3fb63 to d69f74e Compare January 19, 2023 18:00
@tcitworld tcitworld force-pushed the mimeloader-transaction branch from d69f74e to 63088ce Compare January 20, 2023 13:53
@tcitworld
Copy link
Member Author

Lint issues sound unrelated.

@tcitworld tcitworld force-pushed the mimeloader-transaction branch from 63088ce to 18130ab Compare January 23, 2023 09:22
nickvergessen
nickvergessen reviewed Jan 23, 2023
View reviewed changes
lib/private/Files/Type/Loader.php
Comment on lines -111 to +116
* @param int inserted ID
* @return int inserted ID
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch :D

@nickvergessen
Copy link
Member

Might have a negative performance impact, but no clue

@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@szaimen
Copy link
Contributor

szaimen commented Apr 17, 2023

/rebase

@tcitworld @szaimen
Put Mimeloader insertion and read in the same transaction
036cd47 
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@szaimen szaimen enabled auto-merge April 17, 2023 13:36
@szaimen szaimen merged commit 54b5703 into master Apr 17, 2023
@szaimen szaimen deleted the mimeloader-transaction branch April 17, 2023 14:58
@tcitworld tcitworld mentioned this pull request Sep 2, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@artonge artonge Awaiting requested review from artonge

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
5 participants
@tcitworld @nickvergessen @szaimen @come-nc @blizzz