Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let the scanner always update sizes when they differ #35748

Closed
wants to merge 1 commit into from
Closed

Let the scanner always update sizes when they differ #35748

wants to merge 1 commit into from

Conversation

PVince81
Copy link
Member

@PVince81 PVince81 commented Dec 13, 2022 •
edited
Loading

Summary

This helps fixing filecache entries for folders where propagation failed previously, and also fixes the reported used quota.

Not sure if this change has an impact:

TODO

  • clarify if this change will have a side effect:
    • on performance
    • on external storage like object store
    • if yes: maybe we should add a command line switch to toggle this mode
  • request backport

Checklist

@PVince81
Let the scanner always update sizes when they differ
80c526a 
This helps fixing filecache entries for folders where propagation failed
previously, and also fixes the reported used quota.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 added the 3. to review Waiting for reviews label Dec 13, 2022
@PVince81 PVince81 added this to the Nextcloud 26 milestone Dec 13, 2022
@PVince81 PVince81 mentioned this pull request Dec 13, 2022
Closed
@krmax44
Copy link

krmax44 commented Dec 20, 2022

Doesn't seem to fix the issue for me.

@PVince81 PVince81 removed their assignment Jan 11, 2023
@prismopensource
Copy link

Doesn't work for me either, on 25.0.3.

@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@PVince81
Copy link
Member Author

likely obsolete

@PVince81 PVince81 closed this Mar 18, 2023
@solracsf solracsf deleted the filecache-scan-update-size branch June 16, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@icewind1991 icewind1991

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.

Nextcloud displays wrong used storage
5 participants
@PVince81 @krmax44 @prismopensource @icewind1991 @blizzz