-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove comment and guests option from Invitations UI #35761
Conversation
/backport to stable25 |
/backport to stable24 |
/backport to stable23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable
/rebase |
Signed-off-by: Anna Larch <anna@nextcloud.com>
15f471d
to
e6f23f5
Compare
Drone failure is our old friend files sharing acceptance |
Hello! Are you familiar with our documentation process already? Changes that affect administrators should be documented here: While I understand sometimes it's handy to merge fast to get your changes in, it would be great if next time you could try to add the documentation before merging. You can find more information on that here: If all your documentation efforts are done, please remove the label 'pending documentation' and check the checkbox in your opening note and I'll stop bugging you :) Many thanks in advance and thanks again for your work! |
Summary
Sabre doesn't support comments and guests. As such, these values are never passed on to the backend and are never stored anywhere. For the moment, the only solution is to remove the option completely.
Checklist
Screenshots before/after for front-end changes