Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CI): Check for the image-optimization binaries we want to use #36015

Merged
merged 1 commit into from
Jan 5, 2023
Merged

fix(CI): Check for the image-optimization binaries we want to use #36015

merged 1 commit into from
Jan 5, 2023

Conversation

nickvergessen
Copy link
Member

Before

Run

cd build
bash image-optimization.sh

And notice all SVG icons have been deleted....

After

❌ Note about scour missing

Checklist

@nickvergessen
fix(CI): Check for the binaries we want to use
e035c65 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 26 milestone Jan 5, 2023
@nickvergessen nickvergessen self-assigned this Jan 5, 2023
PVince81
PVince81 approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nickvergessen nickvergessen merged commit adef2b8 into master Jan 5, 2023
@nickvergessen nickvergessen deleted the techdebt/36014/fix-image-optimization branch January 5, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @PVince81 @skjnldsv