Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable24] Include more information in iMIP email and show diff information on updating an event #36600

Closed
wants to merge 1 commit into from
Closed

[stable24] Include more information in iMIP email and show diff information on updating an event #36600

wants to merge 1 commit into from

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Feb 8, 2023 •
edited by ChristophWurst
Loading

backport of #35743

@backportbot-nextcloud backportbot-nextcloud bot added bug feature: caldav Related to CalDAV internals labels Feb 8, 2023
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 24.0.10 milestone Feb 8, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 8, 2023
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@blizzz blizzz mentioned this pull request Feb 9, 2023
Merged
@blizzz
Copy link
Member

blizzz commented Feb 9, 2023

conflicts, and moving to 24.0.11

@MichaIng MichaIng added the 2. developing Work in progress label Feb 27, 2023
@blizzz blizzz mentioned this pull request Mar 13, 2023
Merged
@blizzz
Copy link
Member

blizzz commented Mar 15, 2023

@miaulalala 🏓

@miaulalala
Use recurrence instance to build iMip email
a34c7c7 
instead of the main VEVENT of a repeating event

Fixes part of nextcloud/calendar#3919

Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala requested a review from blizzz March 15, 2023 16:07
@miaulalala
Copy link
Contributor

Resolved conflicts and rebased @blizzz

@miaulalala miaulalala added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 15, 2023
tcitworld
tcitworld reviewed Mar 15, 2023
View reviewed changes
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge backport. I'm guessing you have a good reason to backport that, but I'm not very confident while reviewing this.

@blizzz
Copy link
Member

blizzz commented Mar 16, 2023

→ 24.0.12

@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 11, 2023
@miaulalala
Copy link
Contributor

closing as EOL is next month

@miaulalala miaulalala closed this Apr 12, 2023
@ChristophWurst ChristophWurst deleted the backport/35743/stable24 branch April 12, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcitworld tcitworld tcitworld left review comments

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

@miaulalala miaulalala Awaiting requested review from miaulalala miaulalala is a code owner

@blizzz blizzz Awaiting requested review from blizzz

Assignees

@miaulalala miaulalala

Labels
2. developing Work in progress bug feature: caldav Related to CalDAV internals
Projects
None yet
Milestone
Nextcloud 24.0.12
Development

Successfully merging this pull request may close these issues.
5 participants
@blizzz @miaulalala @tcitworld @ChristophWurst @MichaIng