-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add avatar contact img description #36740
Conversation
/backport to stable25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, isn't that worse, as the screenreader reads the name on the avatar and then once again on the actual full-name text?
Do you think we should add a separate label for the avatar @michaelnissenbaum? |
@JuliaKirschenheuter From my perspective, Avatar should not be implemented as a link because we already have a 'View Profile' link that provides the same functionality. Avatar should simply be implemented as an img element with an "alt" attribute set to an empty string, so that screen readers will ignore this element. However, if you really want the Avatar element to remain interactive and be displayed, then you can use the aria-label attribute with an "a"-element or the "alt" attribute of the image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be better to set Avatar of __name__
? Or should we through away a link from avatar #36740 (comment)?
e37426d
to
1748296
Compare
Makes sense UX-wise to have it clickable so updated the description! |
Signed-off-by: Christopher Ng <chrng8@gmail.com>
1748296
to
9d904b1
Compare
Summary
Add descriptive text to the contacts menu avatar
img
elementsChecklist