Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name for home breadcrumb in filepicker #36741

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Feb 16, 2023

Summary

Add name for the home breadcrumb shown below

image

This can be read by screen readers

Checklist

@Pytal
Copy link
Member Author

Pytal commented Feb 16, 2023

/backport to stable25

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me then but didnt test

@Pytal Pytal force-pushed the enh/a11y-filepicker-home-crumb branch from a2b02cd to 6b23155 Compare February 18, 2023 06:32
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 18, 2023
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the enh/a11y-filepicker-home-crumb branch from 6b23155 to 0a9ce1f Compare February 24, 2023 18:31
@Pytal Pytal merged commit 16d7973 into master Feb 24, 2023
@Pytal Pytal deleted the enh/a11y-filepicker-home-crumb branch February 24, 2023 20:28
@blizzz blizzz mentioned this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility feature: filepicker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants