Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add focus border for search results #36771

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Add focus border for search results #36771

merged 1 commit into from
Feb 24, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Feb 18, 2023 •
edited
Loading

Summary

Before After
image image

Checklist

@Pytal Pytal added this to the Nextcloud 26 milestone Feb 18, 2023
@Pytal Pytal self-assigned this Feb 18, 2023
@Pytal
Copy link
Member Author

Pytal commented Feb 18, 2023

/backport to stable25

@Pytal Pytal mentioned this pull request Feb 18, 2023
Closed
10 tasks
szaimen
szaimen approved these changes Feb 18, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@Pytal Pytal force-pushed the enh/a11y-search-result-border branch from adb59c9 to 372d295 Compare February 23, 2023 02:25
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@Pytal
Add focus border for search results
e77b0f6 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the enh/a11y-search-result-border branch from 372d295 to e77b0f6 Compare February 24, 2023 01:21
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 24, 2023
@Pytal Pytal merged commit a47b28f into master Feb 24, 2023
@Pytal Pytal deleted the enh/a11y-search-result-border branch February 24, 2023 02:09
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 24, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@artonge artonge artonge approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility feature: search
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
3 participants
@Pytal @artonge @szaimen