Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid throwing errors on public auth page #36780

Merged
merged 2 commits into from
Feb 20, 2023
Merged

fix: Avoid throwing errors on public auth page #36780

merged 2 commits into from
Feb 20, 2023

Conversation

juliusknorr
Copy link
Member

Avoid throwing errors on the public share page like:

Cannot read properties of null (reading 'addEventListener')

https://juliushaertl.sentry.io/share/issue/2d96706d8b094bd7b5b780761c11969c/

Checklist

@juliusknorr
fix: Avoid throwing errors on public auth page
f3d3dfa 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr requested review from danxuliu, nickvergessen, a team, artonge, Pytal and szaimen and removed request for a team February 20, 2023 08:18
@juliusknorr juliusknorr added this to the Nextcloud 26 milestone Feb 20, 2023
szaimen
szaimen approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@juliusknorr
fix: Fix loading styles from core/css/
4cebfa9 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member Author

Pushed another related fix as styles from core/css were not loaded if called with \OC_Util:.addStyle('core', 'publicshareauth)`.

@juliusknorr juliusknorr merged commit 95eeba8 into master Feb 20, 2023
@juliusknorr juliusknorr deleted the bugfix/noid/console-error-share-auth branch February 20, 2023 11:36
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@artonge artonge artonge approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@Pytal Pytal Awaiting requested review from Pytal Pytal was automatically assigned from nextcloud/server-frontend

Assignees
No one assigned
Labels
3. to review Waiting for reviews 26-feedback bug
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
3 participants
@juliusknorr @artonge @szaimen