Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix max instances exception in get vevent call #36845

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Fix max instances exception in get vevent call #36845

merged 3 commits into from
Apr 17, 2023

Conversation

akhil1508
Copy link
Contributor

@akhil1508 akhil1508 commented Feb 24, 2023 •
edited
Loading

  • This commit handles the MaxInstancesExceededException in most of the cases but misses one
  • Fixing that in this one case as exception is causing reminders to not be fired at all in one of our servers :(

@ChristophWurst ChristophWurst added bug 3. to review Waiting for reviews feature: dav feature: caldav Related to CalDAV internals labels Feb 24, 2023
@szaimen szaimen added this to the Nextcloud 26 milestone Feb 24, 2023
tcitworld
tcitworld approved these changes Feb 26, 2023
View reviewed changes
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(btw, your commit is marked as unverified on Github, you need to upload your key)

@akhil1508
Fix max instances exception for get vevent call
9f9da96 
Signed-off-by: Akhil <akhil@e.email>
@akhil1508
Copy link
Contributor Author

@tcitworld Fixed the sign-off. Thanks

akhil1508 and others added 2 commits February 27, 2023 12:55
@akhil1508 @ChristophWurst
Update apps/dav/lib/CalDAV/Reminder/ReminderService.php
e354e92 
Co-authored-by: Christoph Wurst <ChristophWurst@users.noreply.github.com>
Signed-off-by: Akhil Potukuchi <akhil.potukuchi@gmail.com>
@akhil1508
Remove reminder if max instances exceeded
e823718 
Signed-off-by: Akhil <akhil@e.email>
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 7, 2023
@szaimen szaimen merged commit bdb09ab into nextcloud:master Apr 17, 2023
@welcome
Copy link

welcome bot commented Apr 17, 2023

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@tcitworld tcitworld tcitworld approved these changes

@miaulalala miaulalala miaulalala approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: caldav Related to CalDAV internals feature: dav
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
6 participants
@akhil1508 @ChristophWurst @tcitworld @miaulalala @blizzz @szaimen