-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix right-click img tags #36847
fix right-click img tags #36847
Conversation
/compile amend / |
a951605
to
f643af3
Compare
Are you sure that this fixes #36154? We have still the width and height of the image tag set to 16px and its padding set to 14px. And box-sizing border-box. But this means that regardless of your change the following lines: Lines 1144 to 1147 in 86c102e
will still result in total size of 28px ("border-box" means that content + padding make up for the size, doesn't it?) I have only tested your changes with NC25 and it does not seem to change anything. BTW, also the "Edit locally" menu item is affected and does not show the icon. Is maybe the ":not()" wrong? At least #36154 talks about the very filesActionMenu and the :not() excludes it. So your CSS rules changes do not affect the filesActionMenu. If I remove the |
e1c50fe
to
a415357
Compare
/compile amend / |
Signed-off-by: Simon L <szaimen@e.mail.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
a415357
to
2715f40
Compare
/backport to stable25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to fix the issue. However, I suppose the lines
Lines 1144 to 1147 in 86c102e
> img { | |
width: $popovericon-size; | |
padding: #{math.div($popoveritem-height - $popovericon-size, 2)}; | |
} |
should be revisited as my impression is that these settings do not make sense with box-sizing border-box
. Just mentioned it here because that rule makes the reviewed changes "necessary" and maybe are bogus. But this is probably something for a separate new issue.
Follow-up to #35484
Fix #36832
Fix #36154