Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(profile): Set profile config cache directly after writing it to DB #37170

Closed
wants to merge 1 commit into from
Closed

fix(profile): Set profile config cache directly after writing it to DB #37170

wants to merge 1 commit into from

Commits on Feb 27, 2024

  1. fix(profile): Set profile config cache directly after writing it to DB 

    In ProfileManager::getProfileParams we make a lot of indirect calls to ProfileManager::getProfileConfig. The first time we get the call we get into the catch and insert data, and the next time we miss the cache and do the select. There's a possibility of read-after-write issue here (the database r/o-mirror doesn't have yet the inserted config), which leads to conflicts when it tries to reinsert the config. To avoid that, let's put the config value in the configcache directly when it's written.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
    @tcitworld @AndyScherzinger
    tcitworld authored and AndyScherzinger committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    dc8aecb View commit details
    Browse the repository at this point in the history