[stable25] invalidate existing tokens when deleting an oauth client #37231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
backportbot-nextcloud
bot
requested review from
come-nc,
individual-it and
julien-nc
Merged
come-nc
changed the title
come-nc
force-pushed
the
backport/36033/stable25
branch
from
fae11df to
58fb023
Compare
come-nc
approved these changes
Mar 15, 2023
blizzz
requested changes
Mar 15, 2023
| @@ -92,6 +104,11 @@ public function addClient(string $name, | |||
|
|
|||
| public function deleteClient(int $id): JSONResponse { | |||
| $client = $this->clientMapper->getByUid($id); | |||
|
|
|||
| $this->userManager->callForAllUsers(function (IUser $user) use ($client) { | |||
There was a problem hiding this comment.
do not run against all users, but only against known ones (callForSeenUsers).
Also, this should not run in a user request context, only on the background, as it may take ages.
individual-it
force-pushed
the
backport/36033/stable25
branch
from
58fb023 to
d905b41
Compare
This was referenced Apr 17, 2023
Merged
|
moving to 25.0.8. What is the state with this PR? |
|
all done from my point of view, see discussion in #37230 |
individual-it
force-pushed
the
backport/36033/stable25
branch
from
d905b41 to
c2f71bf
Compare
Merged
blizzz
reviewed
Jun 13, 2023
blizzz
reviewed
Jun 13, 2023
blizzz
approved these changes
Jun 14, 2023
|
@individual-it conflicts 😩 |
Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Artur Neumann <artur@jankaritech.com>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
individual-it
force-pushed
the
backport/36033/stable25
branch
from
9922fee to
28b9cfb
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@blizzz fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #36033