Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File modification date shine through on scroll #37871

Closed
wants to merge 1 commit into from
Closed

File modification date shine through on scroll #37871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions apps/files/templates/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,6 @@

<div id="app-content" tabindex="0">

<input type="checkbox" class="hidden-visually" id="showgridview"
aria-label="<?php p($l->t('Toggle grid view'))?>"
<?php if ($_['showgridview']) { ?>checked="checked" <?php } ?>/>
<label id="view-toggle" for="showgridview" tabindex="0" class="button <?php p($_['showgridview'] ? 'icon-toggle-filelist' : 'icon-toggle-pictures') ?>"
title="<?php p($_['showgridview'] ? $l->t('Show list view') : $l->t('Show grid view'))?>"></label>


<!-- Legacy views -->
<?php foreach ($_['appContents'] as $content) { ?>
<div id="app-content-<?php p($content['id']) ?>" class="hidden viewcontainer">
Expand Down
43 changes: 23 additions & 20 deletions apps/files/templates/list.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,15 @@
*/ ?>
<input type="hidden" id="permissions" value="">
<input type="hidden" id="free_space" value="<?php isset($_['freeSpace']) ? p($_['freeSpace']) : '' ?>">
<?php if (isset($_['dirToken'])):?>
<input type="hidden" id="publicUploadRequestToken" name="requesttoken" value="<?php p($_['requesttoken']) ?>" />
<input type="hidden" id="dirToken" name="dirToken" value="<?php p($_['dirToken']) ?>" />
<?php endif;?>
<input type="hidden" class="max_human_file_size"
value="(max <?php isset($_['uploadMaxHumanFilesize']) ? p($_['uploadMaxHumanFilesize']) : ''; ?>)">
<?php if (isset($_['dirToken'])) : ?>
<input type="hidden" id="publicUploadRequestToken" name="requesttoken" value="<?php p($_['requesttoken']) ?>" />
<input type="hidden" id="dirToken" name="dirToken" value="<?php p($_['dirToken']) ?>" />
<?php endif; ?>
<input type="hidden" class="max_human_file_size" value="(max <?php isset($_['uploadMaxHumanFilesize']) ? p($_['uploadMaxHumanFilesize']) : ''; ?>)">
<?php if (!isset($_["isPublic"])) : ?>
<input type="checkbox" class="hidden-visually notPublic" id="showgridview" aria-label="<?php p($l->t('Toggle grid view')) ?>" <?php if ($_['showgridview']) { ?>checked="checked" <?php } ?> />
<label id="view-toggle" for="showgridview" tabindex="0" class="button notPublic <?php p($_['showgridview'] ? 'icon-toggle-filelist' : 'icon-toggle-pictures') ?>" title="<?php p($_['showgridview'] ? $l->t('Show list view') : $l->t('Show grid view')) ?>"></label>
<?php endif; ?>
</div>
<div class="filelist-header"></div>

Expand All @@ -32,27 +35,27 @@
<h2><?php p($l->t('No entries found in this folder')); ?></h2>
<p></p>
</div>
<table class="files-filestable list-container <?php p($_['showgridview'] ? 'view-grid' : '') ?>" data-allow-public-upload="<?php p($_['publicUploadEnabled'])?>" data-preview-x="250" data-preview-y="250">
<table class="files-filestable list-container <?php p($_['showgridview'] ? 'view-grid' : '') ?>" data-allow-public-upload="<?php p($_['publicUploadEnabled']) ?>" data-preview-x="250" data-preview-y="250">

Check notice

Code scanning / Psalm

PossiblyUndefinedArrayOffset

Possibly undefined array key $_['showgridview'] on ArrayAccess|array{dirToken: mixed, isPublic?: mixed, showgridview?: mixed, uploadMaxHumanFilesize?: mixed, ...<array-key, mixed>}
<thead>
<tr>
<th class="hidden column-selection">
<input type="checkbox" id="select_all_files" class="select-all checkbox"/>
<input type="checkbox" id="select_all_files" class="select-all checkbox" />
<label for="select_all_files">
<span class="hidden-visually"><?php p($l->t('Select all'))?></span>
<span class="hidden-visually"><?php p($l->t('Select all')) ?></span>
</label>
</th>
<th class="hidden column-name">
<div class="column-name-container">
<a class="name sort columntitle" onclick="event.preventDefault()" href="#" data-sort="name">
<span><?php p($l->t('Name')); ?></span>
<span class="sort-indicator"></span>
<span><?php p($l->t('Name')); ?></span>
<span class="sort-indicator"></span>

</a>
<span class="selectedActions">
<a href="#" onclick="event.preventDefault()" class="actions-selected">
<span class="icon icon-more"></span>
<span><?php p($l->t('Actions'))?></span>
</a>
</a>
<span class="selectedActions">
<a href="#" onclick="event.preventDefault()" class="actions-selected">
<span class="icon icon-more"></span>
<span><?php p($l->t('Actions')) ?></span>
</a>
</span>
</div>
</th>
Expand All @@ -73,8 +76,8 @@
<div class="hiddenuploadfield">
<input type="file" id="file_upload_start" class="hiddenuploadfield" name="files[]" />
</div>
<div id="uploadsize-message" title="<?php p($l->t('Upload too large'))?>">
<div id="uploadsize-message" title="<?php p($l->t('Upload too large')) ?>">
<p>
<?php p($l->t('The files you are trying to upload exceed the maximum size for file uploads on this server.'));?>
<?php p($l->t('The files you are trying to upload exceed the maximum size for file uploads on this server.')); ?>
</p>
</div>
</div>