Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show loading spinner until share settings are fully loaded #38163

Merged

Commits on May 10, 2023

  1. Show loading spinner until share settings are fully loaded

    The inputs of the sharing settings are generated in a template in the
    server, but the listeners to react to changes in the elements and save
    the values in the server are loaded in the client once the DOM finishes
    loading. If the DOM takes long to load the user can start to interact
    with the settings before the listeners were set up and, therefore, the
    changes would not be saved in the server. However, as the inputs are
    modified the user would think that the changes were already saved.
    
    To address that now when the sharing settings are open a loading spinner
    is shown instead of the contents of the sharing settings, and only once
    the listeners to save the changes were set up the spinner is removed and
    the contents shown.
    
    Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    danxuliu committed May 10, 2023
    Configuration menu
    Copy the full SHA
    b677d3e View commit details
    Browse the repository at this point in the history