Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show pending popover menu when password is enabled by default #38164

Merged
merged 3 commits into from
May 22, 2023
Merged

Show pending popover menu when password is enabled by default #38164

merged 3 commits into from
May 22, 2023

Commits on May 22, 2023

  1. Rename "pendingPassword" to "pendingEnforcedPassword" 

    Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    @danxuliu @nickvergessen
    danxuliu authored and nickvergessen committed May 22, 2023
    Configuration menu
    Copy the full SHA
    d80f8fc View commit details
    Browse the repository at this point in the history

  2. Show pending popover menu when password is enabled by default 

    When "Enforce password protection" is enabled in the sharing settings a
popover menu is shown to set a password before the share is created. On
the other hand, when "Always ask for a password" was enabled in the
sharing settings and a new link share was created the share was
immediately created with a default password; the user was not able to
specify a password (nor create the share without password).

The component template already provided the needed elements to also ask
for the password without enforcing it, but the popover menu was not
shown due to "enableLinkPasswordByDefault" being missing in "if"
conditions.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    @danxuliu @nickvergessen
    danxuliu authored and nickvergessen committed May 22, 2023
    Configuration menu
    Copy the full SHA
    d463192 View commit details
    Browse the repository at this point in the history

  3. chore(assets): Recompile JS 

    Signed-off-by: Joas Schilling <coding@schilljs.com>
    @nickvergessen
    nickvergessen committed May 22, 2023
    Configuration menu
    Copy the full SHA
    9f8fa48 View commit details
    Browse the repository at this point in the history