Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log failures to read certificates during listing #38468

Merged
merged 1 commit into from
May 31, 2023
Merged

log failures to read certificates during listing #38468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/private/Security/CertificateManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,14 @@ public function listCertificates(): array {
while (false !== ($file = readdir($handle))) {
if ($file != '.' && $file != '..') {
try {
$result[] = new Certificate($this->view->file_get_contents($path . $file), $file);
$content = $this->view->file_get_contents($path . $file);
if ($content !== false) {
$result[] = new Certificate($content, $file);
} else {
$this->logger->error("Failed to read certificate from $path");
icewind1991 marked this conversation as resolved.
Show resolved Hide resolved
}
} catch (\Exception $e) {
$this->logger->error("Failed to read certificate from $path", ['exception' => $e]);
}
}
}
Expand Down