Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace if/else with return match #38622

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Replace if/else with return match #38622

merged 1 commit into from
Nov 14, 2023

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented Jun 2, 2023

Summary

Simple code readability.

Checklist

@solracsf solracsf added the 3. to review Waiting for reviews label Jun 2, 2023
@solracsf solracsf added this to the Nextcloud 28 milestone Jun 2, 2023
@kesselb kesselb requested review from a team, ArtificialOwl, icewind1991 and nfebe and removed request for a team June 2, 2023 18:18
@solracsf solracsf requested a review from fsamapoor July 2, 2023 12:36
@solracsf solracsf added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 17, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
@solracsf
Replace if/else with return match
3bedfdf 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
This was referenced Nov 6, 2023
Merged
Merged
@blizzz blizzz mentioned this pull request Nov 14, 2023
Merged
@solracsf solracsf merged commit e0cafc8 into master Nov 14, 2023
50 checks passed
@solracsf solracsf deleted the ifElseReturnMatch branch November 14, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfebe nfebe nfebe approved these changes

@fsamapoor fsamapoor fsamapoor approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
3 participants
@solracsf @fsamapoor @nfebe