Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable27] Do not cast sizes to int in Trashbin class #38717

Merged
merged 2 commits into from
Jun 9, 2023
Merged

[stable27] Do not cast sizes to int in Trashbin class #38717

merged 2 commits into from
Jun 9, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jun 9, 2023

Manual backport of #38703

come-nc added 2 commits June 9, 2023 08:40
@come-nc @skjnldsv
Do not cast sizes to int in Trashbin class
71adc30 
This helps with 32bits support

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc @skjnldsv
Correctly react to bad configuration
9330739 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Jun 9, 2023
@skjnldsv skjnldsv added this to the Nextcloud 27 milestone Jun 9, 2023
@skjnldsv skjnldsv requested review from AndyScherzinger, come-nc and a team June 9, 2023 06:41
@skjnldsv skjnldsv self-assigned this Jun 9, 2023
@skjnldsv skjnldsv requested review from ArtificialOwl and icewind1991 and removed request for a team June 9, 2023 06:41
This was referenced Jun 9, 2023
Merged
Merged
@skjnldsv skjnldsv changed the title Do not cast sizes to int in Trashbin class [stable27] Do not cast sizes to int in Trashbin class Jun 9, 2023
AndyScherzinger
AndyScherzinger approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise

@skjnldsv skjnldsv merged commit a0a5d5d into stable27 Jun 9, 2023
@skjnldsv skjnldsv deleted the backport/38703/stable27 branch June 9, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@come-nc come-nc Awaiting requested review from come-nc

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @AndyScherzinger @come-nc