Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust saving of status messages #38832

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

Antreesy
Copy link
Contributor

Summary

  • When we select predefined status, it updates and goes to server automatically. Now, we don't update it on 'Set satus', as it's already there.
  • Instead, we check if message was modified (become Custom), and if true, send a custom status to server
  • Also, previously we sent signal on every input @change (that means blurring the input after modifying, pressing Enter to submit and so on). Now, we left only @keyup.enter to immediately submit status, so if we change message to predefined, we don't send last custom message to server
  • In addition, store was modified, so getter is reactive now

TODO

  • Visual and behavior check

Checklist

@Antreesy Antreesy added this to the Nextcloud 28 milestone Jun 15, 2023
@Antreesy Antreesy self-assigned this Jun 15, 2023
@ChristophWurst
Copy link
Member

Sorry. I know too little about status to understand/review the changes.

@ChristophWurst ChristophWurst removed their request for review June 15, 2023 15:07
@Antreesy Antreesy force-pushed the fix/38817/correct-user-status-save branch from 3839a8a to 1982caa Compare June 15, 2023 16:01
@Antreesy Antreesy force-pushed the fix/38817/correct-user-status-save branch from 1982caa to 15e6cec Compare June 26, 2023 11:23
@Antreesy
Copy link
Contributor Author

Wrapped all components with native form, and rebased onto master
Should be tested how it will work with some input methods (Chinese/Japanese/e.t.c)

@nickvergessen
Copy link
Member

nickvergessen commented Jun 26, 2023

Seems to work:
Bildschirmaufzeichnung vom 2023-06-26, 13-54-24.webm

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/38817/correct-user-status-save branch from 15e6cec to bcb074a Compare June 28, 2023 13:39
@Antreesy
Copy link
Contributor Author

Antreesy commented Jun 28, 2023

Rebased onto master and replace three listeners with @input listener only, now we're watching after every input.value change, but submit only on Enter or button click

Tested, seems to work on Linux, but we need to check that for some languages (Chinese, e.t.c) on Windows and MacOS
cc @ShGKme @SystemKeeper

Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Work fine, also tested with IME on Windows 11 and OSX

user-status

@Antreesy Antreesy merged commit 8c73fed into master Jun 28, 2023
@Antreesy Antreesy deleted the fix/38817/correct-user-status-save branch June 28, 2023 17:35
@welcome
Copy link

welcome bot commented Jun 28, 2023

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@szaimen
Copy link
Contributor

szaimen commented Jun 28, 2023

/backport to stable27

@szaimen
Copy link
Contributor

szaimen commented Jun 28, 2023

/backport to stable27

@nickvergessen
Copy link
Member

Backport with compiled JS never works. especially when the node version differs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Status modal closes unexpectedly
5 participants