Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor federatedfilesharing app controllers #39177

Closed
wants to merge 5 commits into from
Closed

refactor federatedfilesharing app controllers #39177

wants to merge 5 commits into from

Conversation

shdehnavi
Copy link
Contributor

Summary

The required adjustments have been made to the classes in /lib/private/Remote namespace.

The improvements:

  • Using PHP8's constructor property promotion
  • Adding return types
  • Adding throws types
  • Adding types to properties
  • Replacing qualifiers with imports

Checklist

@shdehnavi
refactor federatedfilesharing app controllers
589b83a 
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@solracsf solracsf added 3. to review Waiting for reviews technical debt labels Jul 6, 2023
@solracsf solracsf added this to the Nextcloud 28 milestone Jul 6, 2023
shdehnavi added 2 commits July 6, 2023 12:02
@shdehnavi
Make adjustments based on the review
9aee7e0 
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@shdehnavi
Make adjustments based on the review
112b83a 
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@shdehnavi shdehnavi mentioned this pull request Jul 13, 2023
Merged
@shdehnavi @nickvergessen
Make adjustments based on the review
a9dbe71 
Co-authored-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@shdehnavi @nickvergessen
Make adjustments based on the review
6b79ad7 
Co-authored-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@shdehnavi shdehnavi requested a review from nickvergessen July 18, 2023 10:00
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
This was referenced Mar 12, 2024
Merged
Merged
Merged
This was referenced Mar 20, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@skjnldsv skjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024
This was referenced Jul 30, 2024
Merged
Merged
@skjnldsv skjnldsv closed this Aug 3, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin Awaiting requested review from provokateurin

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
2. developing Work in progress stale Ticket or PR with no recent activity technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shdehnavi @nickvergessen @blizzz @solracsf @skjnldsv