Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor core/Controller #39212

Closed
wants to merge 17 commits into from
Closed

Refactor core/Controller #39212

wants to merge 17 commits into from

Conversation

shdehnavi
Copy link
Contributor

Summary

The required adjustments have been made to the classes in /core/Controller namespace.

The improvements:

  • Adding return types
  • Adding throws types
  • Adding types to properties
  • Replacing qualifiers with imports
  • Updating doc blocks
  • Using PHP8's str_starts_with and str_ends_with instead of substr

Checklist

@shdehnavi
Refactor core/Controller
f48db5a 
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@solracsf solracsf added this to the Nextcloud 28 milestone Jul 9, 2023
@solracsf solracsf added 3. to review Waiting for reviews technical debt labels Jul 9, 2023
@shdehnavi shdehnavi mentioned this pull request Jul 13, 2023
Merged
nickvergessen
nickvergessen reviewed Jul 14, 2023
View reviewed changes
core/Controller/GuestAvatarController.php Outdated Show resolved Hide resolved
core/Controller/LoginController.php Outdated Show resolved Hide resolved
core/Controller/PreviewController.php Outdated Show resolved Hide resolved
core/Controller/PreviewController.php Outdated Show resolved Hide resolved
shdehnavi and others added 4 commits July 14, 2023 17:31
@shdehnavi @nickvergessen
Update core/Controller/GuestAvatarController.php
51040b1 
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@shdehnavi @nickvergessen
Make adjustments based on the review
be9e908 
Co-authored-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@shdehnavi @nickvergessen
Make adjustments based on the review
7e4ca27 
Co-authored-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@shdehnavi @nickvergessen
Make adjustments based on the review
dbda422 
Co-authored-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@shdehnavi shdehnavi requested a review from nickvergessen July 16, 2023 12:28
nickvergessen
nickvergessen requested changes Jul 17, 2023
View reviewed changes
core/Controller/ClientFlowLoginController.php Outdated Show resolved Hide resolved
core/Controller/ContactsMenuController.php Outdated Show resolved Hide resolved
core/Controller/CssController.php Outdated Show resolved Hide resolved
core/Controller/JsController.php Outdated Show resolved Hide resolved
core/Controller/LoginController.php Outdated Show resolved Hide resolved
core/Controller/TwoFactorChallengeController.php Outdated Show resolved Hide resolved
core/Controller/TwoFactorChallengeController.php Outdated Show resolved Hide resolved
core/Controller/TwoFactorChallengeController.php Outdated Show resolved Hide resolved
core/Controller/TwoFactorChallengeController.php Outdated Show resolved Hide resolved
core/Controller/WellKnownController.php Outdated Show resolved Hide resolved
shdehnavi and others added 10 commits July 19, 2023 15:52
@shdehnavi @nickvergessen
Update core/Controller/ClientFlowLoginController.php
8913eb8 
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@shdehnavi @nickvergessen
Update core/Controller/CssController.php
f24dc3f 
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@shdehnavi @nickvergessen
Update core/Controller/ContactsMenuController.php
bc5dbd2 
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@shdehnavi @nickvergessen
Update core/Controller/JsController.php
1c942b4 
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@shdehnavi @nickvergessen
Update core/Controller/LoginController.php
2302df8 
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@shdehnavi @nickvergessen
Update core/Controller/TwoFactorChallengeController.php
ee576ef 
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@shdehnavi @nickvergessen
Update core/Controller/TwoFactorChallengeController.php
b169a24 
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@shdehnavi @nickvergessen
Update core/Controller/TwoFactorChallengeController.php
f2b03d1 
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@shdehnavi @nickvergessen
Update core/Controller/WellKnownController.php
cd4bbc5 
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@shdehnavi @nickvergessen
Update core/Controller/TwoFactorChallengeController.php
c54a665 
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@shdehnavi @artonge
Make adjustments based on the review
dde0ef7 
Co-authored-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
nickvergessen
nickvergessen requested changes Jul 19, 2023
View reviewed changes
core/Controller/LoginController.php Outdated Show resolved Hide resolved
core/Controller/PreviewController.php Outdated
Comment on lines 124 to 132
* @param Node $node
* @param int $x
* @param int $y
* @param bool $a
* @param bool $forceIcon
* @param string $mode
* @return Response
* @throws NotFoundException
* @throws InvalidPathException
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this

core/Controller/PreviewController.php Outdated
Comment on lines 89 to 98
*
* @param int $fileId
* @param int $x
* @param int $y
* @param bool $a
* @param bool $forceIcon
* @param string $mode
* @return DataResponse|FileDisplayResponse
* @throws NoUserException
* @throws NotPermittedException
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this

core/Controller/ProfileApiController.php Outdated
Comment on lines 57 to 64
* @param string $targetUserId
* @param string $paramId
* @param string $visibility
* @return DataResponse
* @throws OCSBadRequestException
* @throws OCSForbiddenException
* @throws OCSNotFoundException
* @throws Exception
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another open comment here

core/Controller/TwoFactorChallengeController.php Outdated Show resolved Hide resolved
@shdehnavi
Make adjustments based on the review
78a0f52 
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@shdehnavi shdehnavi requested a review from nickvergessen July 24, 2023 11:52
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
This was referenced Mar 12, 2024
Merged
Merged
Merged
This was referenced Mar 20, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@skjnldsv skjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024
This was referenced Jul 30, 2024
Merged
Merged
@skjnldsv skjnldsv closed this Aug 3, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge Awaiting requested review from artonge

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees
No one assigned
Labels
2. developing Work in progress stale Ticket or PR with no recent activity technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shdehnavi @nickvergessen @artonge @blizzz @solracsf @skjnldsv