(occ db:convert-type) Add support for UNIX sockets #39242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
szaimen
requested review from
a team,
ArtificialOwl,
icewind1991 and
nfebe
and removed request for
a team
nfebe
reviewed
Jul 14, 2023
nfebe
reviewed
Jul 14, 2023
Merged
AndyScherzinger
force-pushed
the
db-convert-type-mysql-socket-no-pw
branch
from
864c17c to
1ac39e7
Compare
This was referenced Mar 12, 2024
Merged
Merged
Merged
skjnldsv
added
2. developing
Merged
|
Hey @joshtrichards |
Fixes nextcloud#31998 Adds support to `occ db:convert-type` to support UNIX socket connections via MySQL/MariaDB. Uses same `dbhost` / `hostname` parameter parsing logic (adapted) as used elsewhere (at least the relevant parts) for consistency. Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
skjnldsv
force-pushed
the
db-convert-type-mysql-socket-no-pw
branch
from
1ac39e7 to
71fff03
Compare
skjnldsv
approved these changes
Aug 16, 2024
|
@joshtrichards as you are a member of Nextcloud organization, could you maybe move this into a local branch? Some CI does not work on forks 😔 |
skjnldsv
added
4. to release
|
Merged, anyway, tests passed locally for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support to
occ db:convert-typeto support UNIX socket connections via MySQL/MariaDB:dbhost/hostnameparameter parsing logic (adapted) as used elsewhere (at least the relevant parts) for consistency.Checklist