-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable26] display displayname on federated shares #39270
Conversation
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
e6e4041
to
b9a25ce
Compare
@@ -335,13 +341,13 @@ | |||
return $result; | |||
} | |||
|
|||
private function notifyAboutNewShare($shareWith, $shareId, $ownerFederatedId, $sharedByFederatedId, $name): void { | |||
private function notifyAboutNewShare($shareWith, $shareId, $ownerFederatedId, $sharedByFederatedId, $name, $displayName): void { |
Check notice
Code scanning / Psalm
MissingParamType
@@ -335,13 +341,13 @@ | |||
return $result; | |||
} | |||
|
|||
private function notifyAboutNewShare($shareWith, $shareId, $ownerFederatedId, $sharedByFederatedId, $name): void { | |||
private function notifyAboutNewShare($shareWith, $shareId, $ownerFederatedId, $sharedByFederatedId, $name, $displayName): void { |
Check notice
Code scanning / Psalm
MissingParamType
@@ -335,13 +341,13 @@ | |||
return $result; | |||
} | |||
|
|||
private function notifyAboutNewShare($shareWith, $shareId, $ownerFederatedId, $sharedByFederatedId, $name): void { | |||
private function notifyAboutNewShare($shareWith, $shareId, $ownerFederatedId, $sharedByFederatedId, $name, $displayName): void { |
Check notice
Code scanning / Psalm
MissingParamType
@@ -335,13 +341,13 @@ | |||
return $result; | |||
} | |||
|
|||
private function notifyAboutNewShare($shareWith, $shareId, $ownerFederatedId, $sharedByFederatedId, $name): void { | |||
private function notifyAboutNewShare($shareWith, $shareId, $ownerFederatedId, $sharedByFederatedId, $name, $displayName): void { |
Check notice
Code scanning / Psalm
MissingParamType
@@ -335,13 +341,13 @@ | |||
return $result; | |||
} | |||
|
|||
private function notifyAboutNewShare($shareWith, $shareId, $ownerFederatedId, $sharedByFederatedId, $name): void { | |||
private function notifyAboutNewShare($shareWith, $shareId, $ownerFederatedId, $sharedByFederatedId, $name, $displayName): void { |
Check notice
Code scanning / Psalm
MissingParamType
@@ -335,13 +341,13 @@ | |||
return $result; | |||
} | |||
|
|||
private function notifyAboutNewShare($shareWith, $shareId, $ownerFederatedId, $sharedByFederatedId, $name): void { | |||
private function notifyAboutNewShare($shareWith, $shareId, $ownerFederatedId, $sharedByFederatedId, $name, $displayName): void { |
Check notice
Code scanning / Psalm
MissingParamType
'strict_search' => true, | ||
]); | ||
try { | ||
$result = \OC::$server->getContactsManager()->search($query, [$property], [ |
Check notice
Code scanning / Psalm
DeprecatedMethod
backport of #35915