Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable26] display displayname on federated shares #39270

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Jul 10, 2023

backport of #35915

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl ArtificialOwl force-pushed the backport/35915/35915-stable26 branch from e6e4041 to b9a25ce Compare July 10, 2023 11:57
@@ -335,13 +341,13 @@
return $result;
}

private function notifyAboutNewShare($shareWith, $shareId, $ownerFederatedId, $sharedByFederatedId, $name): void {
private function notifyAboutNewShare($shareWith, $shareId, $ownerFederatedId, $sharedByFederatedId, $name, $displayName): void {

Check notice

Code scanning / Psalm

MissingParamType

Parameter $shareWith has no provided type
@@ -335,13 +341,13 @@
return $result;
}

private function notifyAboutNewShare($shareWith, $shareId, $ownerFederatedId, $sharedByFederatedId, $name): void {
private function notifyAboutNewShare($shareWith, $shareId, $ownerFederatedId, $sharedByFederatedId, $name, $displayName): void {

Check notice

Code scanning / Psalm

MissingParamType

Parameter $shareId has no provided type
@@ -335,13 +341,13 @@
return $result;
}

private function notifyAboutNewShare($shareWith, $shareId, $ownerFederatedId, $sharedByFederatedId, $name): void {
private function notifyAboutNewShare($shareWith, $shareId, $ownerFederatedId, $sharedByFederatedId, $name, $displayName): void {

Check notice

Code scanning / Psalm

MissingParamType

Parameter $ownerFederatedId has no provided type
@@ -335,13 +341,13 @@
return $result;
}

private function notifyAboutNewShare($shareWith, $shareId, $ownerFederatedId, $sharedByFederatedId, $name): void {
private function notifyAboutNewShare($shareWith, $shareId, $ownerFederatedId, $sharedByFederatedId, $name, $displayName): void {

Check notice

Code scanning / Psalm

MissingParamType

Parameter $sharedByFederatedId has no provided type
@@ -335,13 +341,13 @@
return $result;
}

private function notifyAboutNewShare($shareWith, $shareId, $ownerFederatedId, $sharedByFederatedId, $name): void {
private function notifyAboutNewShare($shareWith, $shareId, $ownerFederatedId, $sharedByFederatedId, $name, $displayName): void {

Check notice

Code scanning / Psalm

MissingParamType

Parameter $name has no provided type
@@ -335,13 +341,13 @@
return $result;
}

private function notifyAboutNewShare($shareWith, $shareId, $ownerFederatedId, $sharedByFederatedId, $name): void {
private function notifyAboutNewShare($shareWith, $shareId, $ownerFederatedId, $sharedByFederatedId, $name, $displayName): void {

Check notice

Code scanning / Psalm

MissingParamType

Parameter $displayName has no provided type
'strict_search' => true,
]);
try {
$result = \OC::$server->getContactsManager()->search($query, [$property], [

Check notice

Code scanning / Psalm

DeprecatedMethod

The method OC\Server::getContactsManager has been marked as deprecated
@solracsf solracsf added the 3. to review Waiting for reviews label Jul 10, 2023
@solracsf solracsf added this to the Nextcloud 26.0.4 milestone Jul 10, 2023
@blizzz blizzz mentioned this pull request Jul 10, 2023
@blizzz blizzz merged commit 48f27a9 into stable26 Jul 10, 2023
@blizzz blizzz deleted the backport/35915/35915-stable26 branch July 10, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants