feat: Move mimetype repair to background jobs #39290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /** | ||
| * Fix mime types | ||
| */ | ||
| public function run(IOutput $out) { |
Check failure
Code scanning / Psalm
ParamNameMismatch
| if (empty($this->folderMimeTypeId)) { | ||
| $query->setParameter('mimetype', 'httpd/unix-directory'); | ||
| $result = $query->execute(); | ||
| $this->folderMimeTypeId = (int)$result->fetchOne(); |
Check failure
Code scanning / Psalm
UndefinedThisPropertyAssignment
|
Perhaps incorporate a check (for Admin->Overview) if it's still "in progress" that reports at info-only level. Maybe with some indication of how far along it is so the user can decide whether they need to do something to push it along faster. |
Merged
Merged
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
|
Replaced by #45930 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move the heavy and slow mime type repair steps into background jobs that are split by storage id.
Some considerations:
The query is quite hard to optimize as we need to check for the file extension on all files
Running an upgrade without this is usually fine as just old files might not immediately show up with the newly introduced mimetypes then
Splitting by storage id seems to be the most reasonable thing to not have massive update transactions, but might not be enough yet
Check if this mass of background jobs can become an issue on large instances, maybe those should be only during off-peak hours but this might have the risk of taking forever then
Still have a way to manually run them, but we'd need to safeguard to not run the jobs then
Checklist