Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable26] getStorage before remove #39355

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

ArtificialOwl
Copy link
Member

backport of #39323

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@blizzz blizzz added this to the Nextcloud 26.0.4 milestone Jul 13, 2023
@blizzz blizzz added the 3. to review Waiting for reviews label Jul 13, 2023
@blizzz blizzz mentioned this pull request Jul 13, 2023
@@ -143,4 +143,10 @@
protected function isApplicable(StorageConfig $config) {
return ($config->getApplicableUsers() === [$this->getUser()->getUID()]) && $config->getType() === StorageConfig::MOUNT_TYPE_PERSONAl;
}

public function removeStorage($id) {

Check notice

Code scanning / Psalm

MissingReturnType

Method OCA\Files_External\Service\UserStoragesService::removeStorage does not have a return type, expecting void
@AndyScherzinger AndyScherzinger merged commit ec0e9dd into stable26 Jul 13, 2023
@AndyScherzinger AndyScherzinger deleted the backport/39323/39323-stable26 branch July 13, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants