Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(request): Add RateLimit and RateLimit-Policy headers #39790

Closed
wants to merge 1 commit into from

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Aug 10, 2023

Summary

Note

I finished the work already, before noticing that https://www.ietf.org/archive/id/draft-ietf-httpapi-ratelimit-headers-07.html is still a draft. So also setting the PR to draft.

Adds the RateLimit and RateLimit-Policy headers, so that clients can see if the next request makes sense. Also it makes debugging rate limits a lot easier.

Checklist

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added the 2. developing Work in progress label Aug 10, 2023
@nickvergessen nickvergessen added this to the Nextcloud 28 milestone Aug 10, 2023
@nickvergessen nickvergessen self-assigned this Aug 10, 2023
@nickvergessen nickvergessen marked this pull request as draft August 10, 2023 09:32
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
@blizzz blizzz mentioned this pull request Nov 6, 2023
@Altahrim Altahrim mentioned this pull request Mar 12, 2024
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024
@skjnldsv skjnldsv closed this Aug 14, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 31 milestone Aug 14, 2024
@skjnldsv skjnldsv deleted the feat/noid/ratelimit-header branch December 19, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants