-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable27] fix(files): Fix legacy files list sorting #39919
Conversation
/backport to stable27 |
921fd9b
to
a1699a3
Compare
@skjnldsv after f2v this is not required on master, but we need this for stable27. |
a1699a3
to
40dec98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for #39808 please 🙏
That way you can also use the cypress selectors
https://github.com/nextcloud/server/blob/feat/f2v/files/cypress/e2e/files.cy.ts
40dec98
to
e79509a
Compare
Changed the base to stable27, as this is no longer needed for master (thanks to f2v :) ). Sorry for the noise Github assigned everyone for a short moment... |
e79509a
to
5a20f0f
Compare
The sorting was not saved since files2vue changes in Nextcloud 27, as a new API endpoint was introduced and the old one was dropped without adjusting the legacy file list to use it. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
5a20f0f
to
cb5c172
Compare
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Summary
The sorting was not saved since files2vue changes in Nextcloud 27, as a new API endpoint was introduced and the old one was dropped without adjusting the legacy file list to use it.
Checklist