Refactor OC\Server::getAppConfig
#40112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summersab
force-pushed
the
refactor/OC-Server-getAppConfig
branch
from
9304ae2 to
f3ae7a8
Compare
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
summersab
force-pushed
the
refactor/OC-Server-getAppConfig
branch
from
f3ae7a8 to
ffb4889
Compare
solracsf
approved these changes
Aug 30, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -98,7 +100,7 @@ | |||
| $application->add(new OC\Core\Command\Config\App\GetConfig(\OC::$server->getConfig())); | |||
| $application->add(new OC\Core\Command\Config\App\SetConfig(\OC::$server->getConfig())); | |||
| $application->add(new OC\Core\Command\Config\Import(\OC::$server->getConfig())); | |||
| $application->add(new OC\Core\Command\Config\ListConfigs(\OC::$server->getSystemConfig(), \OC::$server->getAppConfig())); | |||
| $application->add(new OC\Core\Command\Config\ListConfigs(\OC::$server->getSystemConfig(), \OC::$server->get(IAppConfig::class))); | |||
Check notice
Code scanning / Psalm
DeprecatedMethod
Merged
skjnldsv
approved these changes
Feb 23, 2024
skjnldsv
added
2. developing
|
conflicts |
This was referenced Mar 12, 2024
Merged
Merged
Merged
|
@summersab I closed a few of your Refactor PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the deprecated method
OC\Server::getAppConfigand replaces it withOC\Server::get(\OCP\IAppConfig::class)throughout the entire NC codebase (excluding./appsand./3rdparty).Additionally, where necessary, the
\OCP\IAppConfigclass is imported via theusedirective.