Refactor OC\Server::getCommentsManager
#40117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summersab
force-pushed
the
refactor/OC-Server-getCommentsManager
branch
2 times, most recently
from
a016928 to
b90daea
Compare
Merged
skjnldsv
approved these changes
Mar 15, 2024
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
skjnldsv
force-pushed
the
refactor/OC-Server-getCommentsManager
branch
from
b90daea to
6910832
Compare
skjnldsv
requested review from
a team,
ArtificialOwl,
nfebe and
sorbaugh
and removed request for
a team
Altahrim
approved these changes
Mar 15, 2024
Altahrim
added
4. to release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the deprecated method
OC\Server::getCommentsManagerand replaces it withOC\Server::get(\OCP\Comments\ICommentsManager::class)throughout the entire NC codebase (excluding./appsand./3rdparty).Additionally, where necessary, the
\OCP\Comments\ICommentsManagerclass is imported via theusedirective.