Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor OC\Server::getTrustedDomainHelper #40126

Merged

Conversation

summersab
Copy link
Contributor

This PR refactors the deprecated method OC\Server::getTrustedDomainHelper and replaces it with OC\Server::get(\OC\Security\TrustedDomainHelper::class) throughout the entire NC codebase (excluding ./apps and ./3rdparty).

Additionally, where necessary, the OC\Security\TrustedDomainHelper class is imported via the use directive.

@summersab summersab force-pushed the refactor/OC-Server-getTrustedDomainHelper branch 2 times, most recently from 652d57e to 2df93bb Compare August 30, 2023 02:33
@solracsf solracsf added the 3. to review Waiting for reviews label Aug 30, 2023
@solracsf solracsf added this to the Nextcloud 28 milestone Aug 30, 2023
@kesselb kesselb force-pushed the refactor/OC-Server-getTrustedDomainHelper branch from 2df93bb to 032f118 Compare September 1, 2023 21:14
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 23, 2024
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
@skjnldsv skjnldsv force-pushed the refactor/OC-Server-getTrustedDomainHelper branch from 032f118 to 55eb604 Compare February 23, 2024 14:45
@skjnldsv skjnldsv enabled auto-merge February 23, 2024 14:45
@skjnldsv skjnldsv disabled auto-merge February 23, 2024 18:00
@skjnldsv skjnldsv merged commit f303e95 into nextcloud:master Feb 23, 2024
150 of 158 checks passed
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants