Refactor OC\Server::getEncryptionKeyStorage
#40133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summersab
force-pushed
the
refactor/OC-Server-getEncryptionKeyStorage
branch
2 times, most recently
from
1bd2464 to
d2d8669
Compare
Merged
skjnldsv
approved these changes
Mar 15, 2024
skjnldsv
requested review from
a team,
ArtificialOwl,
icewind1991 and
nfebe
and removed request for
a team
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
skjnldsv
force-pushed
the
refactor/OC-Server-getEncryptionKeyStorage
branch
from
d2d8669 to
6cc147c
Compare
Altahrim
approved these changes
Mar 15, 2024
Altahrim
requested changes
Mar 15, 2024
This was referenced Mar 18, 2024
Merged
Merged
Merged
Co-authored-by: Benjamin Gaussorgues <github-fa3ie@altahrim.net> Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
skjnldsv
added
3. to review
artonge
approved these changes
May 30, 2024
Altahrim
approved these changes
May 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the deprecated method
OC\Server::getEncryptionKeyStorageand replaces it withOC\Server::get(\OCP\Encryption\Keys\IStorage::class)throughout the entire NC codebase (excluding./appsand./3rdparty).Additionally, where necessary, the
OCP\Encryption\Keys\IStorageclass is imported via theusedirective.