refactor(f2v): Migrate unread comments action to the new FileAction API #40409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate inline unread comments action to the new FileAction API.
To display the inline action as a icon only button, I had to remove the
force-name
prop from the<NcActions />
in theFileEntry.vue
, otherwise theNcButton
is rendered with text as well. But I imagine the action buttons were meant to be icon only, so I guess this was unintentionally added?Screenshots
TODO
Vue.set()
to overwrite thecomments-unread
attribute and rely on reactivity to disable the action?Checklist
Documentation (manuals or wiki) has been updated or is not requiredBackports requested where applicable (ex: critical bugfixes)