Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(a11y): Add label to share note textbox #40430

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Sep 15, 2023

Summary

Before After
image image

Checklist

@nfebe
Copy link
Contributor

nfebe commented Sep 18, 2023

/backport to stable27

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the enh/a11y/share-note-label branch from f8adbd9 to 39adf3a Compare September 28, 2023 00:39
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 28, 2023
@nfebe nfebe merged commit c5293bb into master Sep 28, 2023
38 checks passed
@nfebe nfebe deleted the enh/a11y/share-note-label branch September 28, 2023 11:54
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility backport-request feature: file sidebar Related to the file sidebar component feature: sharing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants