Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow external drop and add dropzone #40674

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 28, 2023

Drag and drop in current folder (with tall header because of recommended files)
Drop in sub-folder Narrow height header look

Fix #4483

@nextcloud/designers for visual input

@skjnldsv skjnldsv self-assigned this Sep 28, 2023
@skjnldsv skjnldsv added enhancement 3. to review Waiting for reviews labels Sep 28, 2023
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 28 Sep 28, 2023
@skjnldsv skjnldsv mentioned this pull request Sep 28, 2023
26 tasks
@skjnldsv skjnldsv requested review from artonge, Pytal, a team and susnux and removed request for a team September 28, 2023 08:33
@tcitworld
Copy link
Member

How does it handle rich workspaces?

@skjnldsv

This comment was marked as resolved.

Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but not a fan of how it looks :/
Have we looked at how others are doing it ?

apps/files/src/components/FileEntry.vue Outdated Show resolved Hide resolved
@skjnldsv

This comment was marked as resolved.

@nimishavijay

This comment was marked as resolved.

@skjnldsv

This comment was marked as resolved.

@artonge

This comment was marked as resolved.

@jancborchardt

This comment was marked as resolved.

@skjnldsv

This comment was marked as resolved.

@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 10, 2023

@nimishavijay @jancborchardt please advise updated design in the first comment!

@skjnldsv
Copy link
Member Author

@nimishavijay @jancborchardt please advise updated design in the first comment!

Design tuning can/will be a followup though

@nimishavijay
Copy link
Member

Nice! This looks good already, nice touch with the folder opening icon :)

Follow up points:

  • While dragging in the header, if your cursor is hovering over the header, there should be some hover feedback, similar to when your cursor is over a subfolder. So the background of the header section can change to --color-primary-light and the font color to --color-primary for example.
  • Since this is shown only while dragging, the message could be even more attention grabbing, so we could make the font bold

(ref. Gdrive's drop indication which is really attention grabbing)
image

@skjnldsv
Copy link
Member Author

  • While dragging in the header, if your cursor is hovering over the header, there should be some hover feedback, similar to when your cursor is over a subfolder. So the background of the header section can change to --color-primary-light and the font color to --color-primary for example.

Those two colours doesn't really go together? Is this a mistake? :)

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 10, 2023
@skjnldsv skjnldsv merged commit 73f5d1d into master Oct 10, 2023
40 checks passed
@skjnldsv skjnldsv deleted the feat/drop-folder branch October 10, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Introduce a notice for instant upload / drag&drop in below file list
7 participants