Make sure blob columns are correctly converted as parameters #4071
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
3. to review
|
@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bantu, @bartv2 and @MorrisJobke to be potential reviewers. |
|
I'd like to backport this to 11, so we can tell people that they can migrate away from sqlite on 11+ at least, @karlitschek |
|
nice. please backport 👍 |
Codecov Report
@@ Coverage Diff @@
## master #4071 +/- ##
============================================
- Coverage 54.24% 54.23% -0.01%
- Complexity 21285 21292 +7
============================================
Files 1310 1310
Lines 81187 81199 +12
Branches 1284 1284
============================================
+ Hits 44036 44037 +1
- Misses 37151 37162 +11
Continue to review full report at Codecov.
|
core/Command/Db/ConvertType.php
Outdated
| } | ||
|
|
||
| $prefix = $this->config->getSystemValue('dbtableprefix', 'oc_'); | ||
| $this->columnTypes[$table][$column] = null; |
There was a problem hiding this comment.
setting this makes no difference, isset will also return false if the value is null.
There was a problem hiding this comment.
Right, I used a different value before...
Signed-off-by: Joas Schilling <coding@schilljs.com>
|
Is there anyway to have tests for this? |
|
The problem is, I can create a test whether the |
Fix #173
Fix #3536