Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dav): implement personal absence settings #40767

Merged
merged 1 commit into from
Nov 8, 2023
Merged

feat(dav): implement personal absence settings #40767

merged 1 commit into from
Nov 8, 2023

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Oct 4, 2023 •
edited
Loading

Summary

The new absence form is hidden/disabled by default. It has to be manually enabled via the app config hide_absence_settings.

The help texts and descriptions might some need more work once the feature is fleshed out.

grafik

TODO

Checklist

@st3iny st3iny added this to the Nextcloud 28 milestone Oct 4, 2023
@st3iny st3iny self-assigned this Oct 4, 2023
@st3iny st3iny mentioned this pull request Oct 11, 2023
Merged
2 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 16, 2023
View reviewed changes
apps/dav/lib/Db/Absence.php Fixed Show fixed Hide fixed
apps/dav/lib/Settings/AvailabilitySettings.php
$this->initialState->provideInitialState('hide_absence', $hideAbsence);
if (!$hideAbsence) {
try {
$absence = $this->absenceMapper->findByUserId($this->userId);

Check notice

Code scanning / Psalm

PossiblyNullArgument Note

Argument 1 of OCA\DAV\Db\AbsenceMapper::findByUserId cannot be null, possibly null value provided
This was referenced Oct 23, 2023
Merged
Closed
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
@st3iny st3iny marked this pull request as ready for review November 1, 2023 20:57
@st3iny st3iny added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 1, 2023
@st3iny st3iny requested a review from ChristophWurst November 1, 2023 21:05
@blizzz blizzz mentioned this pull request Nov 6, 2023
Merged
@st3iny
feat(dav): implement personal absence settings
425e770 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny
Copy link
Member Author

st3iny commented Nov 7, 2023

Rebase round 2 to finally get green CI 🙃

hamza221
hamza221 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@hamza221 hamza221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ✅

@ChristophWurst ChristophWurst merged commit 1d568a8 into master Nov 8, 2023
49 checks passed
@ChristophWurst ChristophWurst deleted the feat/dav/absence branch November 8, 2023 04:51
@nickvergessen
Copy link
Member

Could this be moved into an OCS endpoint so talk mobile clients could set the OOO as well?

@ChristophWurst ChristophWurst mentioned this pull request Nov 14, 2023
Closed
@ChristophWurst
Copy link
Member

Good idea! #41458

nickvergessen
nickvergessen reviewed Nov 14, 2023
View reviewed changes
apps/dav/src/components/AbsenceForm.vue
lastDay: formatDateAsYMD(this.lastDay),
status: this.status,
message: this.message,
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should show success after this?

apps/dav/src/components/AbsenceForm.vue
async clearAbsence() {
this.loading = true
try {
await axios.delete(generateUrl('/apps/dav/settings/absence'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should show success after this?

@ChristophWurst ChristophWurst mentioned this pull request Nov 27, 2023
Merged
4 tasks
@tflidd
Copy link
Contributor

tflidd commented Dec 11, 2023

For translation, I'm not 100% sure of the strings Long absence Message and Short absence status,

  • in case of an absence, there is a short status message and a long message (e.g. if you hover over it)
  • or is there a short-term absence with a status message, and a long-term absence (e.g. after >5 min) where it shows a different message)?

I tend to the first option, but in this case it would make sense to define the different kind of absence status like in other software (e.g. busy, away, available, ....)

@nickvergessen
Copy link
Member

The first one. the "Short" is set as "User status", the long one is shown in Mail and Talk close to the inputs iirc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@hamza221 hamza221 hamza221 approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@kesselb kesselb Awaiting requested review from kesselb

Assignees

@st3iny st3iny

Labels
3. to review Waiting for reviews enhancement feature: dav
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

Out-of-office: Implement settings UI with persistence in database
5 participants
@st3iny @nickvergessen @ChristophWurst @tflidd @hamza221