Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(session): Log why session renewal failed #40859

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Oct 11, 2023

Summary

This is a follow-up to #40785, which logs

{
  "reqId": "wEtQ6wYq1uWybvZebFcb",
  "level": 3,
  "time": "2023-10-11T06:18:27+00:00",
  "remoteAddr": "abc:def::",
  "user": "--",
  "app": "core",
  "method": "GET",
  "url": "/",
  "message": "Renewing session token failed",
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/117.0.0.0 Safari/537.36",
  "version": "27.1.2.1",
  "data": {
    "app": "core",
    "user": "user123"
  },
  "id": "65264067911b1"
}

but doesn't tell me the reason for the renewal error.

Checklist

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added the 3. to review Waiting for reviews label Oct 11, 2023
@ChristophWurst ChristophWurst self-assigned this Oct 11, 2023
@ChristophWurst
Copy link
Member Author

/backport to stable27

@ChristophWurst
Copy link
Member Author

/backport to stable26

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 11, 2023
@solracsf solracsf added this to the Nextcloud 28 milestone Oct 27, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
@ChristophWurst ChristophWurst merged commit b2c0cd9 into master Nov 2, 2023
38 of 40 checks passed
@ChristophWurst ChristophWurst deleted the fix/session/log-why-session-renewal-failed branch November 2, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
Development

Successfully merging this pull request may close these issues.

5 participants