Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(files): grid view #40917

Merged
merged 9 commits into from
Oct 17, 2023
Merged

feat(files): grid view #40917

merged 9 commits into from
Oct 17, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Oct 14, 2023 •
edited
Loading

Ref #39914
Fix #36993

image

@skjnldsv skjnldsv added this to the Nextcloud 28 milestone Oct 14, 2023
@skjnldsv skjnldsv self-assigned this Oct 14, 2023
@skjnldsv skjnldsv mentioned this pull request Oct 14, 2023
Closed
26 tasks
artonge
artonge reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is mostly moving code around, should we give a closer look to a specific area? Beside the virtual list improvement ;)

@skjnldsv
Copy link
Member Author

As this is mostly moving code around, should we give a closer look to a specific area? Beside the virtual list improvement ;)

The grid view! 😁
a495933

@skjnldsv skjnldsv changed the title chore(files): split FileEntry Preview feat(files): grid view Oct 16, 2023
@artonge
Copy link
Contributor

artonge commented Oct 16, 2023 •
edited
Loading

Beware, the target branch seems off

@skjnldsv
Copy link
Member Author

Beware, the target branch seems off

On purpose, please also review #40854

@skjnldsv skjnldsv force-pushed the fix/template-picker branch from e6f4d4f to 0b654a5 Compare October 17, 2023 06:30
@skjnldsv skjnldsv requested review from a team, nfebe, szaimen and sorbaugh and removed request for a team October 17, 2023 07:03
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 17, 2023
@skjnldsv skjnldsv force-pushed the fix/template-picker branch from 0b654a5 to 4b55594 Compare October 17, 2023 09:17
Base automatically changed from fix/template-picker to master October 17, 2023 09:17
@skjnldsv
chore(files): split FileEntry Preview
60260bb 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
fix(files): split FileEntry Checkbox and fix range selection
0f1f734 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
fix(files): split FileEntry Actions
64c32f7 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
fix(files): split FileEntry Name
694fd51 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
feat(files): grid view
16975ae 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
perf(files): reuse keys for virtual scrolling
c4b8abd 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
feat(files): add grid toggle button
116c396 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
szaimen

This comment was marked as resolved.

Sign in to view

@skjnldsv
Copy link
Member Author

But it seems to be broken on mobile currently

The grid view button will be hidden on mobile (you can toggle it in the settings also)

Also for the first elements the 3-dot menu is not shown:

👍

@skjnldsv
perf(files): optimize virtual scroller computation
77fdef1 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv requested a review from szaimen October 17, 2023 10:14
szaimen

This comment was marked as resolved.

Sign in to view

@skjnldsv
Copy link
Member Author

Also done @szaimen

@skjnldsv skjnldsv requested a review from szaimen October 17, 2023 10:37
@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 17, 2023 •
edited
Loading

PS: not recompiling as I see other PRs are probably going in too
EDIT: Actually, this one might get in first 🚀

@skjnldsv
fix(files): hide grid view button on narrow screen
1ba5bc0 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
szaimen
szaimen reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last problem and then ready to go:

on small displays and If in grid view and opening the dropdown on the right it shows multiple scroll bars:
image

szaimen
szaimen approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem shall be fixed in follow-up

@szaimen szaimen mentioned this pull request Oct 17, 2023
Open
@skjnldsv skjnldsv merged commit 106bf6c into master Oct 17, 2023
37 of 39 checks passed
@skjnldsv skjnldsv deleted the feat/gridview branch October 17, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@artonge artonge artonge approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-frontend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews enhancement feature: files performance 🚀
Projects
Files to vue
Status: Done
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

[BITV] 9.2.4.3/3.7 - "Change view" button - The button has been implemented as a checkbox with a label. (2)
3 participants
@skjnldsv @artonge @szaimen