Lower some session warnings to debug level #41195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
8 tasks
|
/backport to stable27 |
|
/backport to stable26 |
|
Are either of the changes in this PR for the specific message being spammed in #41156? The message in that issue seems to be:
|
| @@ -802,12 +802,11 @@ private function validateToken($token, $user = null) { | |||
| 'app' => 'core', | |||
| 'user' => $dbToken->getUID(), | |||
| ]); | |||
|
|
|||
| return false; | |||
| } | |||
|
|
|||
| if (!$this->checkTokenCredentials($dbToken, $token)) { | |||
There was a problem hiding this comment.
inside this method there are critical paths that might still be worth logging. That is every time \OC\Authentication\Token\IProvider::invalidateToken or markPasswordInvalid is called, for example.
There was a problem hiding this comment.
Maybe in a follow up PR? Otherwise, feel free to commit them as output messages would require a deeper knowledge of what they exactly accomplish, which I don't have. 🦺
Merged
|
Closing as #41302 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
No need to Warn about these, and they can be noisy.
Resolves #41156
Checklist