-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dav): multiple fixes in usage of webdav library #41202
Conversation
pulsejet
commented
Oct 30, 2023
- Refresh token on update
- Fix some very weird imports
- Patch fetch instead of request to prevent accessing impl details
nextcloud/server#41202 Signed-off-by: Varun Patil <varunpatil@ucla.edu>
Can you clarify what is this about? :) |
nextcloud/server#41202 Signed-off-by: Varun Patil <varunpatil@ucla.edu>
nextcloud/server#41202 Signed-off-by: Varun Patil <varunpatil@ucla.edu>
3a50a40
to
59c544c
Compare
To patch import { request } from 'webdav/dist/node/request.js' This is an implementation detail of the webdav library and also needs the node polyfills. Instead we can just patch BTW, fixed the style to align with nextcloud-files |
I want to point out that things might be broken without this patch in 28. When the refresh token changes, the WebDAV clients are never updated in RC.1 This is not a feature, it's a fix to a regression. |
59c544c
to
3422780
Compare
3422780
to
0b0ea51
Compare
/compile amend / |
a8cde62
to
410bddd
Compare
CI failure seems unrelated |
1. Refresh token on update 2. Fix some very weird imports 3. Patch fetch instead of request to prevent accessing impl details Signed-off-by: Varun Patil <varunpatil@ucla.edu>
410bddd
to
b03fd6e
Compare