Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OCM): Fix OCM provider discovery for servers without beautiful URLs #41234

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nickvergessen
Copy link
Member

Resolves

  • This allows to do federation with instances again that do not support "beautiful" URLs at all.

Checklist

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

/backport to stable27

@nickvergessen
Copy link
Member Author

/backport to stable26

@nickvergessen nickvergessen mentioned this pull request Nov 2, 2023
10 tasks
@kesselb
Copy link
Contributor

kesselb commented Nov 2, 2023

I'm not familiar with ocm 🙈

  1. Isn't that against the spec to query index.php/ocm-provider
  2. Wouldn't that break if the remote instance is not Nextcloud

@nickvergessen
Copy link
Member Author

Isn't that against the spec to query index.php/ocm-provider

If it is, we need to recreate the folder with it's index.php like it was before #39574

Wouldn't that break if the remote instance is not Nextcloud

Right. Quick fix suggestion: go back to "first query without index.php and if that gives a 404 we try with index.php, or implement the folder again.

@blizzz blizzz mentioned this pull request Nov 6, 2023
@level420
Copy link

@nickvergessen could this also solve the problem that since v 27.1.x (now having 27.1.3) I'm getting warnings about unresolvable "/ocm-provider/" in the security and warnings section?

My instances are running without pretty urls enabled, and https://myinstance.com/index.php/ocm-provider/ works, but https://myinstance.com/ocm-provider/ not.

I'm running a docker stack using the current nextcloud docker image nextcloud:27.1-fpm which is behind an apache httpd proxy.

@nickvergessen
Copy link
Member Author

yeah that was exactly the attempt.

atm you can fix it by running occ maintenance:update:htaccess (Docs at https://docs.nextcloud.com/server/latest/admin_manual/configuration_server/occ_command.html )

This was referenced Nov 10, 2023
@blizzz blizzz mentioned this pull request Nov 20, 2023
5 tasks
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@Altahrim Altahrim mentioned this pull request Mar 12, 2024
@nickvergessen
Copy link
Member Author

@sorbaugh @ArtificialOwl What's the state with this.
With the upcoming Talk federation work it will be quite more annoying again.

This was referenced Mar 14, 2024
@Altahrim Altahrim mentioned this pull request Mar 25, 2024
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
81 tasks
@blizzz blizzz mentioned this pull request Apr 4, 2024
67 tasks
@blizzz blizzz mentioned this pull request Apr 8, 2024
67 tasks
@nickvergessen nickvergessen removed this from the Nextcloud 29 milestone Apr 8, 2024
@susnux susnux added this to the Nextcloud 30 milestone Apr 18, 2024
@skjnldsv skjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024
This was referenced Jul 30, 2024
@skjnldsv skjnldsv marked this pull request as draft November 15, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress backport-request bug feature: federation stale Ticket or PR with no recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants