Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Only highlight profile entry when viewing own profile #41251

Merged
merged 1 commit into from
Nov 6, 2023
Merged

fix: Only highlight profile entry when viewing own profile #41251

merged 1 commit into from
Nov 6, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Nov 2, 2023

Summary

  • Fix highlighting profile entry when viewing another user's profile

Checklist

@Pytal
fix: Only highlight profile entry when viewing own profile
7f530d2 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added bug 3. to review Waiting for reviews labels Nov 2, 2023
@Pytal Pytal added this to the Nextcloud 28 milestone Nov 2, 2023
@Pytal Pytal self-assigned this Nov 2, 2023
szaimen
szaimen approved these changes Nov 5, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 6, 2023
@Pytal Pytal merged commit 045e152 into master Nov 6, 2023
49 checks passed
@Pytal Pytal deleted the fix/profile-active branch November 6, 2023 17:25
@blizzz blizzz mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@nfebe nfebe Awaiting requested review from nfebe

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
3 participants
@Pytal @nickvergessen @szaimen