feat(location): introduce a public API for location providers #41255
+2,279
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently each app does location search & geocoding itself, and it's limited to OpenStreetMap's public Nominatim service. This will allow people to install other app providers, such as Google Maps, Pelias, OpenCage, Photon, etc. This will also allow some providers to provide autocomplete support. Signed-off-by: Thomas Citharel <tcit@tcit.fr>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| try { | ||
| return $provider->geocode($longitude, $latitude, $options); | ||
| } catch (RuntimeException $e) { | ||
| $this->logger->warning("Failed to geocode coords {$longitude}:${latitude} using provider {$provider->getName()}", ['exception' => $e]); |
Check failure
Code scanning / Psalm
UndefinedInterfaceMethod Error
| try { | ||
| return $provider->search($address, $options); | ||
| } catch (RuntimeException $e) { | ||
| $this->logger->warning("Failed to search for location {$address} using provider {$provider->getName()}", ['exception' => $e]); |
Check failure
Code scanning / Psalm
UndefinedInterfaceMethod Error
| return $provider->autocomplete($address, $options); | ||
| } | ||
| } catch (RuntimeException $e) { | ||
| $this->logger->warning("Failed to autocomplete location {$address} using provider {$provider->getName()}", ['exception' => $e]); |
Check failure
Code scanning / Psalm
UndefinedInterfaceMethod Error
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently each app does location search & geocoding itself, and it's limited to OpenStreetMap's public Nominatim service. This will allow people to install other app providers, such as Google Maps, Pelias, OpenCage, Photon, etc. This will also allow some providers to provide autocomplete support.
TODO
Checklist