fix(workflowengine): use andWhere() not second where() #41417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
requested review from
nickvergessen,
a team,
Altahrim,
Fenn-CS and
sorbaugh
and removed request for
a team
|
/backport to stable27 |
|
/backport to stable26 |
nickvergessen
approved these changes
Nov 13, 2023
kesselb
approved these changes
Nov 13, 2023
mejo-
approved these changes
Nov 13, 2023
come-nc
approved these changes
Nov 13, 2023
- an unconditional where() condition is added right before - fixes also wrongly named methods in the Exception message Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
kesselb
force-pushed
the
fix/noid/use-andWhere-not-where
branch
from
a6ad2cc
to
93505b2
Compare
|
Pressed rebase because drone timed out 🤞 |
blizzz
added
4. to release
|
the tests of the app passed locally, so lets save the CI time |
This was referenced Nov 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When saving a Flow configuration, a
QueryExceptionis logged, but without interrupting the code flow. It rightfully complains about not usingandWhere()against the query builder, after awhere()is already effective.Checklist